Incorporate changes from test262/41edfcebce1a85096 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds André Bargull's simplifications with some slight edits to prevent printing error messages for hashbang tests, and to always load the local monkeyYaml script.
|
ping :) |
|
Once this is merged, we can (finally!) enable these tests in V8. 👍🏻🎉 |
leobalter
approved these changes
Mar 12, 2019
| if (parsed is None): | ||
| print "Failed to parse yaml in name %s"%(name) | ||
| #def onerror(message): | ||
| # print(message) |
|
Thanks @leobalter 🙏 |
|
This change broke test262.py script because you removed stripHeader function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds @anba's simplifications with some slight edits to prevent
printing error messages for hashbang tests, and to always load the local
monkeyYaml script.